Fix classpath relative-to-absolute conversion in DotenvReader #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 25, 2022 09:54
Escape "." to prevent removing the trailing character from a simple directory name with no leading "/" or "./"
Anchor the regex to prevents stripping a trailing literal "." from a directory name, which is unlikely but possible
Add tests for simple resource directory and resource directory with trailing "."
Examples of bug:
.directory("envdir") would try to load "resources/envdi/.env" and fail.
.directory("/trailingdot./envdir") would try to load "resources/trailingdot/envdir/.env") and fail.
cdimascio
approved these changes
May 29, 2022
|
@all-contributors add @Mooninaut for code and test |
|
I've put up a pull request to add @Mooninaut! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape
.to prevent removing the trailing character from a simple directory name with no leading/or./Anchor the regex to prevent stripping a trailing literal
.from a directory name, which is unlikely but possibleAdd tests for simple resource directory and resource directory with trailing
.Examples of bug:
.directory("envdir")would try to loadresources/envdi/.envand fail.directory("/trailingdot./envdir")would try to loadresources/trailingdot/envdir/.envand failWorkaround: Always prefix classpath-relative directories with
./