Upgrade to Java 11 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copy-rename-maven-plugin, using the project artifactId and version tags. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>
- Using Java 11 everywhere (instead of 1.8 for sources and 11 for tests) - Update dependency versions Signed-off-by: Manoel Campos <manoelcampos@gmail.com>
Since the project is already using https://codacy.com, they already provide coverage service which doesn't require a maven plugin. Uploading coverage reports can be done inside a GitHub Action workflow. This way, a single service can be used for code quality and coverage. The coveralls plugin is abandoned, has old dependencies and doesn't support new JDK versions. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>
Signed-off-by: Manoel Campos <manoelcampos@gmail.com>
- Refactor tests - Organize test code Signed-off-by: Manoel Campos <manoelcampos@gmail.com>
- Define final variable and parameters. - Code organization. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>
(without changing behaviour) Signed-off-by: Manoel Campos <manoelcampos@gmail.com>
extracting a new method to improve clarity. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>
…rse() and creates an ArrayList with that exact size for memory improvement. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>
Signed-off-by: Manoel Campos <manoelcampos@gmail.com>
- Update build badge - Remove coveralls badge since the plugin was removed (since it's abandoned) and codacy can be configured to show code coverage. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic High Entropy Secret | 13e267a | pom.xml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
@all-contributors add @manoelcampos for code test infrastructure |
|
I've put up a pull request to add @manoelcampos! 🎉 |
manoelcampos
added a commit
to manoelcampos/env-file-maven-plugin
that referenced
this pull request
May 2, 2023
Signed-off-by: Manoel Campos <manoelcampos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 8 is end-of-life. It was released almost 10 years ago.
Maybe Java 11 is the most established Java LTS version. I think it's the minimum requirement for any updated Java project.
If there is someone still using Java 8, they can stick with dotenv 2.3.2.
Contributions of this PR