Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support from reading from jimfs in-memory FS #60

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

clintval
Copy link
Contributor

@clintval clintval commented Dec 18, 2023

Closes #59

Draft PR to use upstream's CI harness to make sure this works OK.

@cdimascio have any ideas for how I could test this?

@clintval clintval marked this pull request as ready for review December 18, 2023 19:36
@cdimascio
Copy link
Owner

Can you provide some background on the addition of jimfs. What is the use case and benefit of this change?

@clintval
Copy link
Contributor Author

@cdimascio it's far from a critical feature for me. I wanted to use an in-memory file system for Groovy unit tests so I wouldn't have to write files in my temp directory. You can see that here:

https://github.com/fulcrumgenomics/nf-dotenv/blob/b4c64f84cbd237ee7be2729545e26b174f57bb24/plugins/nf-dotenv/src/test/nextflow/dotenv/MockHelpers.groovy#L36-L53

I'm using your library under-the-hood of a plugin I developed for a scientific workflow manager. Instead, I implemented my testing with real temporary files on a real filesystem.

@clintval
Copy link
Contributor Author

This is the project that uses your library: nf-dotenv

@cdimascio cdimascio merged commit 0c5642e into cdimascio:master Dec 25, 2023
2 checks passed
@clintval clintval deleted the cv_jimfs_support branch December 25, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jimfs support
2 participants