chore: notice for https://github.com/aws/aws-cdk/issues/24668 #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
data/notices.json
Outdated
| @@ -1,5 +1,21 @@ | |||
| { | |||
| "notices": [ | |||
| { | |||
| "title": "aws-wafv2: Reverted the naming pattern change where some structs changed from Foo to FooAction", | |||
There was a problem hiding this comment.
I find it a bit confusing that we are focusing on what was reverted rather than what they will see. In other words, FooAction -> Foo is easier to understand than revert Foo -> FooAction, even though logically they are equivalent.
There was a problem hiding this comment.
I see, ok will make the change.
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
otaviomacedo
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI notice for WAFv2 RuleGroup struct name changes.
Being patched here: aws/aws-cdk#24651