Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

bug: tests in change-analysis-models failing #10

Open
BryanPan342 opened this issue Jul 15, 2021 · 0 comments
Open

bug: tests in change-analysis-models failing #10

BryanPan342 opened this issue Jul 15, 2021 · 0 comments

Comments

@BryanPan342
Copy link
Contributor

This e44c28f introduced a breaking change in the codebase.

The problem is the constructor of model entity:

constructor(entityType: string, nodeData: fn.InVertex<ND>, outgoingNodeReferences: OR){
this.nodeData = {_entityType: entityType, _id: `${++ModelEntity.idCounter}`, ...nodeData};
this.outgoingNodeReferences = outgoingNodeReferences;
}

and the deserializer, which creates a new Model Entity. The static increment in the constructor makes the _id's to appear differently.

Fix:

  • Bind id later
  • Have a simple check to see if there is a _id in the NodeData (requires refactoring for EACH deserializer to pass down _id)
BryanPan342 added a commit that referenced this issue Jul 15, 2021
* cache node_modules and add linting to pr workflow
* commit templates (we should have templates as a shared resource)
* updates to workspaces and lerna
* get everything to finally build

COMMENTING OUT TESTS IN `cdk-change-analyzer-models` see #10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant