chore: introduce the Synthesizer trait
#101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial work ot generalize the contract of synthesizers to prepare for addition of more target languages. The current API is very bare bones, and may be modified/expanded in the future.
iph
reviewed
Apr 17, 2023
iph
reviewed
Apr 17, 2023
| pub fn output(ir: CloudformationProgramIr) -> String { | ||
| let output = &mut String::new(); | ||
| let mut output = Vec::new(); |
There was a problem hiding this comment.
AHHHH, much cleaner of an interface to write tests against. I'm a fan of this.
iph
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work to generalize the contract of synthesizers to prepare for addition of more target languages. The current API is very bare bones, and may be modified/expanded in the future.