Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: further simplify parsing from YAML #121

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

RomainMuller
Copy link
Contributor

Directly deserialize into the end data structure and get rid of all the older APIs that were used to that purpose. Added test coverage around conditions, etc...

Moved from HashMap to IndexMap to preserve order of elements where relevant, as this provides a deterministic, reliable experience to customers.

Directly deserialize into the end data structure and get rid of all the
older APIs that were used to that purpose. Added test coverage around
conditions, etc...

Moved from HashMap to IndexMap to preserve order of elements where
relevant, as this provides a deterministic, reliable experience to
customers.
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 78.53% and project coverage change: +10.00 🎉

Comparison is base (97fa628) 47.48% compared to head (ac8998a) 57.48%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #121       +/-   ##
===========================================
+ Coverage   47.48%   57.48%   +10.00%     
===========================================
  Files          21       21               
  Lines        2622     2585       -37     
===========================================
+ Hits         1245     1486      +241     
+ Misses       1377     1099      -278     
Impacted Files Coverage Δ
src/errors/mod.rs 41.66% <0.00%> (-13.89%) ⬇️
src/ir/constructor.rs 0.00% <0.00%> (ø)
src/ir/importer.rs 0.00% <0.00%> (ø)
src/ir/outputs.rs 0.00% <0.00%> (ø)
src/parser/output.rs 0.00% <0.00%> (-8.07%) ⬇️
src/parser/parameters.rs 0.00% <0.00%> (-12.50%) ⬇️
src/synthesizer/typescript_synthesizer.rs 6.97% <0.00%> (ø)
src/ir/resources.rs 21.87% <14.89%> (+1.10%) ⬆️
src/specification/mod.rs 41.52% <25.00%> (ø)
src/ir/mappings.rs 87.32% <33.33%> (+1.21%) ⬆️
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HBobertz HBobertz merged commit 6d897a8 into main May 3, 2023
@HBobertz HBobertz deleted the rmuller/index-map branch May 3, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants