Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: track reference origin nullability #129

Merged
merged 10 commits into from
May 10, 2023
Merged

Conversation

RomainMuller
Copy link
Contributor

Allows emitting optional-chained references when the origin is conditional, so as to avoid the TypeScript compiler complaining about possibly null dereference.

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #129 (30d754a) into main (169a091) will decrease coverage by 58.2%.
The diff coverage is 39.1%.

Additional details and impacted files
Components Coverage Δ
Parser 39.5% <ø> (-57.8%) ⬇️
Intermediate Representation 38.8% <39.1%> (-50.6%) ⬇️
Synthesizers 32.4% <ø> (-55.6%) ⬇️
Other 17.4% <ø> (-57.9%) ⬇️
@@           Coverage Diff            @@
##            main    #129      +/-   ##
========================================
- Coverage   91.3%   33.1%   -58.2%     
========================================
  Files         22      22              
  Lines       2762    2820      +58     
  Branches       0    1340    +1340     
========================================
- Hits        2521     934    -1587     
- Misses       241     893     +652     
- Partials       0     993     +993     
Impacted Files Coverage Δ
src/errors/mod.rs 16.7% <ø> (-25.0%) ⬇️
src/ir/conditions.rs 27.2% <ø> (-45.4%) ⬇️
src/ir/resources.rs 38.3% <16.7%> (-51.4%) ⬇️
src/ir/reference.rs 39.2% <42.9%> (-37.1%) ⬇️
src/ir/mod.rs 56.1% <64.3%> (-41.3%) ⬇️

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 169a091...30d754a. Read the comment docs.

@RomainMuller
Copy link
Contributor Author

NOTE - Coverage now is branch-aware, and Coverall reports "fully covered" only, so this is a more accurate view, although perhaps a bit scary

@RomainMuller RomainMuller merged commit dd830eb into main May 10, 2023
@RomainMuller RomainMuller deleted the rmuller/output-format branch May 10, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants