Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow split/select to be used in conditions #150

Merged
merged 7 commits into from
Jun 12, 2023
Merged

Conversation

iph
Copy link
Collaborator

@iph iph commented Jun 2, 2023

Turns out you can use split (and probably join) in conditions. This adds the functionality for split to be used, which unblocks a few templates found that require that.

iph added 7 commits June 2, 2023 13:18
Turns out you can use split (and probably join) in conditions. This
adds the functionality for split to be used, which unblocks a few
templates found that require that.
@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #150 (049a33a) into main (1e58e80) will increase coverage by 0.2%.
The diff coverage is 90.0%.

Additional details and impacted files
Components Coverage Δ
Parser 75.2% <68.8%> (-0.2%) ⬇️
Intermediate Representation 81.7% <100.0%> (+0.3%) ⬆️
Synthesizers 87.5% <100.0%> (+0.2%) ⬆️
Other 49.7% <ø> (ø)
@@           Coverage Diff           @@
##            main    #150     +/-   ##
=======================================
+ Coverage   81.4%   81.5%   +0.2%     
=======================================
  Files         24      24             
  Lines       2693    2743     +50     
  Branches    2693    2743     +50     
=======================================
+ Hits        2191    2236     +45     
  Misses       342     342             
- Partials     160     165      +5     
Impacted Files Coverage Δ
src/parser/condition/mod.rs 76.4% <68.8%> (-0.7%) ⬇️
src/ir/conditions/mod.rs 69.2% <100.0%> (+3.1%) ⬆️
src/synthesizer/golang/mod.rs 84.6% <100.0%> (+0.3%) ⬆️
src/synthesizer/typescript/mod.rs 90.6% <100.0%> (+0.2%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e58e80...049a33a. Read the comment docs.

@iph iph changed the title feat: allow split to be used in conditions feat: allow split/select to be used in conditions Jun 3, 2023
@iph iph requested review from RomainMuller and HBobertz and removed request for RomainMuller June 6, 2023 12:50
@HBobertz HBobertz merged commit ba9aaf6 into main Jun 12, 2023
@HBobertz HBobertz deleted the split-support branch June 12, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants