Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow Conditions to be used in isolation #151

Merged
merged 5 commits into from
Jun 12, 2023
Merged

feat: Allow Conditions to be used in isolation #151

merged 5 commits into from
Jun 12, 2023

Conversation

iph
Copy link
Collaborator

@iph iph commented Jun 3, 2023

Apparently conditions can just be "another condition". Weird use case, but I've found some templates that have this. Added Condition as the highest level to allow those templates to work.

iph added 4 commits June 3, 2023 10:28
Apparently conditions can just be "another condition". Weird use
case, but I've found some templates that have this. Added Condition
as the highest level to allow those templates to work.
@iph iph requested review from RomainMuller and HBobertz June 6, 2023 12:50
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #151 (2b5a7e2) into main (fff7f0d) will increase coverage by 0.4%.
The diff coverage is 88.9%.

Additional details and impacted files
Components Coverage Δ
Parser 77.1% <81.8%> (+2.0%) ⬆️
Intermediate Representation 81.8% <100.0%> (+0.1%) ⬆️
Synthesizers 87.6% <100.0%> (+<0.1%) ⬆️
Other 49.7% <ø> (ø)
@@           Coverage Diff           @@
##            main    #151     +/-   ##
=======================================
+ Coverage   81.5%   81.9%   +0.4%     
=======================================
  Files         24      24             
  Lines       2743    2758     +15     
  Branches    2743    2758     +15     
=======================================
+ Hits        2236    2258     +22     
+ Misses       342     334      -8     
- Partials     165     166      +1     
Impacted Files Coverage Δ
src/parser/condition/mod.rs 80.9% <81.8%> (+4.5%) ⬆️
src/ir/conditions/mod.rs 70.1% <100.0%> (+0.9%) ⬆️
src/synthesizer/golang/mod.rs 84.6% <100.0%> (+<0.1%) ⬆️
src/synthesizer/typescript/mod.rs 90.6% <100.0%> (+<0.1%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff7f0d...2b5a7e2. Read the comment docs.

@iph iph merged commit d30df7d into main Jun 12, 2023
@iph iph deleted the condition-hoist branch June 12, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants