Translate ResourceValue to ResourceIr to add metadata #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resources in intermediate representation was the last holdover to a working program without manual manipulation of typescript. This change adds "Complexity", a concept to help translate CDK interfaces appropriately for L1s, and adds this decoration to ResourceIr. This change also adds a few other bells and whistles along the way while debugging final output (like AWS::AccountId)
roblaks
approved these changes
Nov 11, 2021
| let spec = spec(); | ||
| let mut resource_instructions = Vec::new(); | ||
| for resource in parse_tree.resources.resources.iter() { | ||
| let resource_spec = spec |
There was a problem hiding this comment.
Nit: This is more of an optimization question. Does this need to be done for every iteration? Can we save resource_spec after the first time we see the type?
There was a problem hiding this comment.
I'm a bit confused, as each resource is more than likely unique, and the lookup is O(1) already (as it's backed by a hashmap in spec).
Comment on lines
+142
to
+152
| let opt = match property_rule.get_complexity() { | ||
| Complexity::Simple(_) => Option::None, | ||
| Complexity::Complex(x) => { | ||
| let mut ret = | ||
| format!("{}.{}", resource_translator.resource_type, x); | ||
| if x == "Tag" { | ||
| ret = "Tag".to_string(); | ||
| } | ||
| Option::Some(ret) | ||
| } | ||
| }; |
There was a problem hiding this comment.
Worth moving to its own method since it's re-used in two places?
There was a problem hiding this comment.
Yeah. I'ma push so we got a working application but will then update to clean this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources in intermediate representation was the last holdover
to a working program without manual manipulation of typescript.
This change adds "Complexity", a concept to help translate CDK
interfaces appropriately for L1s, and adds this decoration to
ResourceIr. This change also adds a few other bells and whistles
along the way while debugging final output (like AWS::AccountId)