Add option to write output to a file and fix minor TypeScript coding style & formatting issues. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 16, 2022 23:45
…style & formatting issues.
iph
reviewed
Mar 18, 2022
Comment on lines
320
to
324
| if false_expr == "{}" { | ||
| "undefined".to_string() | ||
| } else { | ||
| false_expr | ||
| } |
There was a problem hiding this comment.
iirc: It's more idiomatic to use match. Also, I think the only time {} comes about is above in the None case -- so we can just replace to undefined there.
There was a problem hiding this comment.
Thanks. That is indeed cleaner.
|
Just sent out new revision. |
iph
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR cannot be updated for some reason. So I am creating a new one.
Can you help squash the commits on the UI before merging?