Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling Custom::<CustomName> when synthesizing custom resources #60

Merged
merged 1 commit into from
May 17, 2022

Conversation

sandeepklr
Copy link
Contributor

@sandeepklr sandeepklr commented May 17, 2022

Notes

Handling Custom:: when synthesizing custom resources. Originally thought about converting all Custom:: resource types to AWS::CloudFormation::CustomResource in resources/translates_resources(), but given immutability turned out to be a more involved option.

Testing

Output:

const resourceType = new cloudformation.CfnCustomResource(this, 'Name', {
         serviceToken: FunctionName.attrArn
});

@iph iph merged commit 0998673 into cdklabs:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants