Add capability to parse and convert floats in CFN templates #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem?
As is noctilucent is unable to convert a CFN template if there exists floats in the template. I ran into this on the Threshold property for a CloudWatch alarm, but looking at the specification, there are a couple different resources that could run into this (any property that allows a Double)
What is the solution?
While parsing, we will check if a string is an integer or not, using https://docs.rs/numberkit/latest/numberkit/fn.is_digit.html. If it is we will continue with today's parsing, otherwise we will use a new ResourceValue::Double. The not straightforward thing that I had to do was create essentially a wrapper around the f64 type as it does not implement Eq.
Example error
when trying to convert the following resource:
I get the following error:
After this change
I am able to get the stack converted 💯
(Generated typescript:
(Disclaimer: I've never written rust before so let me know if there is a better way to do this)