(fix): Sub variables only saw References #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, when the Sub parser goes through, you can get a blob like:
```
"Fn::Sub": "echo ${lol}"
```
which would transform lol into a variable, as it's surrounded by ${}.
It turns out that CFN doesn't need a reference of any kind, and will just
output the string inside if it doesn't match any origin. Meanwhile, my system
would attempt to topological sort `lol` off a Logical Id, but not find a Logical
Id! So it would crash.
There were a few other bugs in this patch (escaping ticks, simplify the parser) that
aren't worth mentioning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, when the Sub parser goes through, you can get a blob like:
which would transform lol into a variable, as it's surrounded by ${}. It turns out that CFN doesn't need a reference of any kind, and will just output the string inside if it doesn't match any origin. Meanwhile, my system would attempt to topological sort
loloff a Logical Id, but not find a Logical Id! So it would crash.There were a few other bugs in this patch (escaping ticks, simplify the parser) that aren't worth mentioning.