(IGNORE) Update GitHub Actions workflows to remove outdated steps (#296) #1

Sign in to view logs

GitHub Actions / clippy failed Oct 5, 2023 in 1s

clippy

12 errors

Details

Results

Message level	Amount
Internal compiler error	0
Error	12
Warning	0
Note	0
Help	0

Versions

rustc 1.73.0 (cc66ad468 2023-10-03)
cargo 1.73.0 (9c4383fb5 2023-08-26)
clippy 0.1.73 (cc66ad4 2023-10-03)

Annotations

Check failure on line 149 in sdk/src/utils/hash_utils.rs

github-actions / clippy

use of `unwrap_or` to construct default value

error: use of `unwrap_or` to construct default value
   --> sdk/src/utils/hash_utils.rs:149:67
    |
149 |     hash_stream_by_alg(alg, &mut reader, Some(inclusions), false).unwrap_or(Vec::new())
    |                                                                   ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Check failure on line 142 in sdk/src/utils/hash_utils.rs

github-actions / clippy

use of `unwrap_or` to construct default value

error: use of `unwrap_or` to construct default value
   --> sdk/src/utils/hash_utils.rs:142:60
    |
142 |     hash_stream_by_alg(alg, &mut reader, exclusions, true).unwrap_or(Vec::new())
    |                                                            ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Check failure on line 229 in sdk/src/time_stamp.rs

github-actions / clippy

redundant closure

error: redundant closure
   --> sdk/src/time_stamp.rs:229:33
    |
229 |                         .decode(|cons| SignedData::take_from(cons))
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `SignedData::take_from`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

Check failure on line 159 in sdk/src/store.rs

github-actions / clippy

use of `unwrap_or` to construct default value

error: use of `unwrap_or` to construct default value
   --> sdk/src/store.rs:159:69
    |
159 |             Store::calc_manifest_box_hash(claim, None, claim.alg()).unwrap_or(Vec::new())
    |                                                                     ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Check failure on line 149 in sdk/src/utils/hash_utils.rs

github-actions / clippy

use of `unwrap_or` to construct default value

error: use of `unwrap_or` to construct default value
   --> sdk/src/utils/hash_utils.rs:149:67
    |
149 |     hash_stream_by_alg(alg, &mut reader, Some(inclusions), false).unwrap_or(Vec::new())
    |                                                                   ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Check failure on line 142 in sdk/src/utils/hash_utils.rs

github-actions / clippy

use of `unwrap_or` to construct default value

error: use of `unwrap_or` to construct default value
   --> sdk/src/utils/hash_utils.rs:142:60
    |
142 |     hash_stream_by_alg(alg, &mut reader, exclusions, true).unwrap_or(Vec::new())
    |                                                            ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Check failure on line 229 in sdk/src/time_stamp.rs

github-actions / clippy

redundant closure

error: redundant closure
   --> sdk/src/time_stamp.rs:229:33
    |
229 |                         .decode(|cons| SignedData::take_from(cons))
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `SignedData::take_from`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

Check failure on line 159 in sdk/src/store.rs

github-actions / clippy

use of `unwrap_or` to construct default value

error: use of `unwrap_or` to construct default value
   --> sdk/src/store.rs:159:69
    |
159 |             Store::calc_manifest_box_hash(claim, None, claim.alg()).unwrap_or(Vec::new())
    |                                                                     ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Check failure on line 162 in sdk/src/asn1/rfc5652.rs

github-actions / clippy

redundant closure

error: redundant closure
   --> sdk/src/asn1/rfc5652.rs:162:53
    |
162 |         Constructed::decode(data, bcder::Mode::Ber, |cons| Self::decode(cons))
    |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Self::decode`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
    = note: `#[deny(clippy::redundant_closure)]` implied by `#[deny(warnings)]`

Check failure on line 162 in sdk/src/asn1/rfc5652.rs

github-actions / clippy

redundant closure

error: redundant closure
   --> sdk/src/asn1/rfc5652.rs:162:53
    |
162 |         Constructed::decode(data, bcder::Mode::Ber, |cons| Self::decode(cons))
    |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Self::decode`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
    = note: `#[deny(clippy::redundant_closure)]` implied by `#[deny(warnings)]`

Check failure on line 127 in sdk/src/assertions/ingredient.rs

github-actions / clippy

use of `unwrap_or_else` to construct default value

error: use of `unwrap_or_else` to construct default value
   --> sdk/src/assertions/ingredient.rs:127:38
    |
127 |         let metadata = self.metadata.unwrap_or_else(Metadata::new);
    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
note: the lint level is defined here
   --> sdk/src/lib.rs:14:9
    |
14  | #![deny(warnings)]
    |         ^^^^^^^^
    = note: `#[deny(clippy::unwrap_or_default)]` implied by `#[deny(warnings)]`

Check failure on line 127 in sdk/src/assertions/ingredient.rs

github-actions / clippy

use of `unwrap_or_else` to construct default value

error: use of `unwrap_or_else` to construct default value
   --> sdk/src/assertions/ingredient.rs:127:38
    |
127 |         let metadata = self.metadata.unwrap_or_else(Metadata::new);
    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
note: the lint level is defined here
   --> sdk/src/lib.rs:14:9
    |
14  | #![deny(warnings)]
    |         ^^^^^^^^
    = note: `#[deny(clippy::unwrap_or_default)]` implied by `#[deny(warnings)]`

View more details on GitHub Actions