Add jquery.turbolinks v2.1.0 #7604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with npm auto-update config added, close cdnjs#7254
|
@dannyxx001 Please help me review this PR, thank you. |
| { | ||
| "basePath": "", | ||
| "files": [ | ||
| "vendor/assets/javascripts/*" |
There was a problem hiding this comment.
I think you can use "vendor/assets/javascripts/" as basepath and "jquery.turbolinks*" as files in npmFileMap, but I'm not very sure. @PeterDaveHello Would you please explain again that whether only "dist" and "build" can be basepath? Thank you.
There was a problem hiding this comment.
In this case, vendor/assets/javascripts/ or vendor/assets/ could be the base path, maybe you can discuss with its author and see if it's possible add a dist folder for release files?
This was referenced Apr 19, 2016
|
Any updates here? Thanks! |
2 similar comments
|
Any updates here? Thanks! |
|
Any updates here? Thanks! |
19 tasks
pvnr0082t
pushed a commit
to sufuf3/cdnjs
that referenced
this pull request
Jul 12, 2017
close cdnjs#7604, close cdnjs#7254, cc cdnjs#11170
pvnr0082t
pushed a commit
to sufuf3/cdnjs
that referenced
this pull request
Jul 12, 2017
- Add repository info - Update authors and keywords cc cdnjs#7604, cdnjs#7254, cdnjs#11170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #7254
Checklist for Pull request or lib adding request issue follows the conventions.
Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.
Profile of the lib
Essential checklist
Auto-update checklist
Git commit checklist
with npm auto-update config added, close #7254