Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable deletion protection on all DynamoDB tables #580

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

craigzour
Copy link
Contributor

Summary | Résumé

closes #561

  • Enable deletion protection on all DynamoDB tables

@craigzour craigzour self-assigned this Jan 15, 2024
Copy link

⚠ Terrform update available

Terragrunt: 0.54.17 (using 0.54.8)

Copy link

Staging: dynamodb

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 3 to change, 0 to destroy
Show summary
CHANGE NAME
update aws_dynamodb_table.audit_logs
aws_dynamodb_table.reliability_queue
aws_dynamodb_table.vault
Show plan
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # aws_dynamodb_table.audit_logs will be updated in-place
  ~ resource "aws_dynamodb_table" "audit_logs" {
      ~ deletion_protection_enabled = false -> true
        id                          = "AuditLogs"
        name                        = "AuditLogs"
        tags                        = {}
        # (12 unchanged attributes hidden)

        # (7 unchanged blocks hidden)
    }

  # aws_dynamodb_table.reliability_queue will be updated in-place
  ~ resource "aws_dynamodb_table" "reliability_queue" {
      ~ deletion_protection_enabled = false -> true
        id                          = "ReliabilityQueue"
        name                        = "ReliabilityQueue"
        tags                        = {}
        # (8 unchanged attributes hidden)

        # (4 unchanged blocks hidden)
    }

  # aws_dynamodb_table.vault will be updated in-place
  ~ resource "aws_dynamodb_table" "vault" {
      ~ deletion_protection_enabled = false -> true
        id                          = "Vault"
        name                        = "Vault"
        tags                        = {}
        # (12 unchanged attributes hidden)

        # (11 unchanged blocks hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Show Conftest results
WARN - plan.json - main - Missing Common Tags: ["aws_dynamodb_table.audit_logs"]
WARN - plan.json - main - Missing Common Tags: ["aws_dynamodb_table.reliability_queue"]
WARN - plan.json - main - Missing Common Tags: ["aws_dynamodb_table.vault"]

22 tests, 19 passed, 3 warnings, 0 failures, 0 exceptions

Copy link
Contributor

@bryan-robitaille bryan-robitaille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@craigzour craigzour merged commit 62a00aa into develop Jan 15, 2024
4 checks passed
@craigzour craigzour deleted the feature/enable-deletion-protection-on-dynamodb branch January 15, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable delete protection to our DynamoDB tables
2 participants