fix Vpn and gh secrets

[ben851]

Summary | Résumé

Convert VPN to autofetch config

Convert to github secrets to ones managed by TF

Related Issues | Cartes liées

• https://app.zenhub.com/workspaces/notify-planning-core-6411dfb7c95fb80014e0cab0/issues/gh/cds-snc/notification-planning-core/299

Test instructions | Instructions pour tester la modification

Docker build and push runs

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

• This PR does not break existing functionality.
• This PR does not violate GCNotify's privacy policies.
• This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
• This PR does not significantly alter performance.
• Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

[github-actions]

A review app will be deployed. Get the URL by going to https://cds-snc.github.io/notification-documentation/

[github-actions]

Review Apps

URLS

• review-apps

Last updated at

Thu Nov 28 2024 16:14:13 GMT+0000 (Coordinated Universal Time)