Add early return for responses page when a form hasn't been saved yet #3824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://oage3dgwd3rwngx5titsgiwini0pnzhn.lambda-url.ca-central-1.on.aws/ |
timarney
commented
Jun 12, 2024
| @@ -38,6 +38,21 @@ export default async function Page({ | |||
| overdueAfter: Number(await getAppSetting("nagwarePhaseEncouraged")), | |||
| }; | |||
|
|
|||
| // Handle the case where the user is not authenticated and the form ID is 0000 | |||
| // In this case we know no responses will be returned, so we can skip the API call | |||
| if (isAuthenticated && id === "0000") { | |||
There was a problem hiding this comment.
This should check for a UUID vs just 0000
dsamojlenko
approved these changes
Jun 12, 2024
|
Noting other string will still fall-through but will merge this. |
dsamojlenko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Fixes issue where a user could land on the responses page with a form that has never been saved (doesn't have form responses).
Adds early return to avoid API lookup which throws