Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add early return for responses page when a form hasn't been saved yet #3824

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Add early return for responses page when a form hasn't been saved yet #3824

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45c72e8
add early return
timarney Jun 12, 2024
8ab8d5e
Merge branch 'develop' into fix/no-responses-api-lookup
timarney Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...forms)/[locale]/(form administration)/form-builder/[id]/responses/[statusFilter]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,21 @@ export default async function Page({
overdueAfter: Number(await getAppSetting("nagwarePhaseEncouraged")),
};

// Handle the case where the user is not authenticated and the form ID is 0000
// In this case we know no responses will be returned, so we can skip the API call
if (isAuthenticated && id === "0000") {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should check for a UUID vs just 0000

return (
<Responses
initialForm={null}
nagwareResult={null}
lastEvaluatedKey={null}
overdueAfter={pageProps.overdueAfter}
responseDownloadLimit={pageProps.responseDownloadLimit}
vaultSubmissions={[]}
/>
);
}

try {
if (isAuthenticated) {
const initialForm = await fetchTemplate(id);
Expand Down
Loading