fix: Adds focus heading behavior for forms with pages (groups) #4201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://mgedsw4nqa5zyqnnpkvcd4aglu0jedqz.lambda-url.ca-central-1.on.aws/ |
thiessenp-cds
changed the title
timarney
reviewed
Aug 26, 2024
| callback, | ||
| }: { | ||
| language: Language; | ||
| callback?: () => void; |
There was a problem hiding this comment.
Wondering if there's a better name for this maybe just onClick?
callback makes me think of something that's going to happen after a function call happens which isn't exactly what's happing here.
timarney
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Adds focus header behavior for forms with lengthy pages. Focussing the group header (H2) navigates the page to the top and also announces the change (heading title) for AT users.
Test
Create a form with a few pages that have a lot of form elements. I found adding a few address component sets helpful for this. Then try navigating back and forth through the form. For each page navigation, the focus should start at the top of the form.