Add support for specifying formatter config #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Zheng <felix.zheng@mongodb.com>
Signed-off-by: Felix Zheng <felix.zheng@mongodb.com>
|
LGTM. |
shaobo-he-aws
approved these changes
Oct 14, 2024
dtaveras
approved these changes
Oct 14, 2024
adpaco-aws
approved these changes
Oct 16, 2024
|
Thanks for your contribution @felixzheng98 |
felixzheng98
added a commit
to felixzheng98/cedar-java
that referenced
this pull request
Oct 19, 2024
Signed-off-by: Felix Zheng <felix.zheng@mongodb.com>
felixzheng98
added a commit
to felixzheng98/cedar-java
that referenced
this pull request
Oct 19, 2024
Signed-off-by: Felix Zheng <felix.zheng@mongodb.com>
cdisselkoen
pushed a commit
that referenced
this pull request
Oct 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds support for specifying a formatter config.
It adds a new method to the Java
PolicyFormattercalledpoliciesStrToPrettyWithConfigthat accepts aConfigobject. This is mapped to acedar_policy_formatter::Configstruct and used for calling the formatter.