Fix isAuthorizedPartial due to rust interface changes #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdisselkoen
approved these changes
Nov 14, 2024
Signed-off-by: Mohamed Amine Ouali <mdamine@amazon.com>
adpaco-aws
approved these changes
Nov 18, 2024
|
I believe the PR is ready to be merged if there are no concerns |
amzn-mdamine
added a commit
to amzn-mdamine/cedar-java
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Mohamed Amine Ouali <mdamine@amazon.com>
Merged
shaobo-he-aws
pushed a commit
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a commit that changes the rust interface for isAuthorizedPartial method. The current PR fix the problem by making the necessary changes.
isAuthorizedPartialwas never working since the rust change was made so it is safe to assume that no client use it currently.There were unit tests for isAuthorizedPartial method however they were not being executed correctly.
In the unit test the assumePartialEvaluation return an executor that was never executed.
Reference in the code:
https://github.com/cedar-policy/cedar-java/blob/main/CedarJava/src/test/java/com/cedarpolicy/AuthTests.java#L92
https://github.com/cedar-policy/cedar-java/blob/main/CedarJava/src/test/java/com/cedarpolicy/AuthTests.java#L103