Improved failure messaging for Equals matcher #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just had a quick look at this. Seems very nice! I'm also happy to see there's no templating involved. 😀 One potential issue I see is that the new implementation files are presumably being built with MRC, so I think there are some leaks in there? |
|
Good catch @briancroom; I'l fix that shortly. |
If two objects fail to match Equal but have identical -description, Cedar will use the -(NSString *)cdr_explicitDescription instead, if they respond to that selector. Initial support is provided on NSArray,NSDictionary,NSSet,NSOrderedSet and these implementations will annotate the collection members with their class names.
idoru
force-pushed
the
disambiguate-equal-matcher-collection-failures
branch
from
b80bcee to
c2321e9
Compare
|
I believe c2321e9 has now eliminated those leaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If two objects fail to match Equal but have identical -description,
Cedar will use the -(NSString *)cdr_explicitDescription instead, if
they respond to that selector.
Initial support is provided on NSArray,NSDictionary,NSSet,NSOrderedSet
and these implementations will annotate the collection members with
their class names.