Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OffScreen Don't create Browser when assigning to OnBeforePopup #1170

Closed
amaitland opened this issue Aug 4, 2015 · 1 comment
Closed

OffScreen Don't create Browser when assigning to OnBeforePopup #1170

amaitland opened this issue Aug 4, 2015 · 1 comment
Labels
offscreen
Milestone
43.0.1

Comments

@amaitland
Copy link
Member

When using a custom ChromiumWebBrowser instance to host a popup we shouldn't call CreateBrowser.

https://github.com/cefsharp/CefSharp/blob/master/CefSharp.OffScreen/ChromiumWebBrowser.cs#L97
https://github.com/cefsharp/CefSharp/blob/master/CefSharp.OffScreen/ChromiumWebBrowser.cs#L97
@amaitland amaitland added this to the 43.0.0 milestone Aug 4, 2015
@amaitland amaitland modified the milestones: 45.0.0, 43.0.0 Sep 9, 2015
@amaitland
Copy link
Member Author

Low priority so bumping to 45 milestone. If someone needs this then a PR is most welcome!

@amaitland amaitland modified the milestones: 47.0.0, 45.0.0 Oct 11, 2015
@amaitland amaitland mentioned this issue Oct 13, 2015
Closed
@amaitland amaitland modified the milestones: 45.0.0, 47.0.0 Oct 15, 2015
amaitland added a commit that referenced this issue Oct 17, 2015
@amaitland
OffScreen - Allow for the delayed creation of the underlying OffScree…
d0460e5 
…nBrowser, useful for binding and potentially using as an custom popup implementation (when that eventually works properly)

Resolves #1170
@amaitland amaitland modified the milestones: 43.0.1, 45.0.0 Oct 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
offscreen
Projects
None yet
Milestone
43.0.1
Development

No branches or pull requests
1 participant
@amaitland