Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Cef.EnableHighDPISupport #4417

Closed
amaitland opened this issue Mar 7, 2023 · 0 comments
Closed

Remove Cef.EnableHighDPISupport #4417

amaitland opened this issue Mar 7, 2023 · 0 comments
Assignees
@amaitland
Labels
api-change breaking-change
Milestone
112.2.x

Comments

@amaitland
Copy link
Member

amaitland commented Mar 7, 2023 •
edited
Loading

High-DPI support is now enabled by default in Chromium. As a result CEF has removed the CefEnableHighDPISupport method.

https://bitbucket.org/chromiumembedded/cef/commits/f3b570cf8e3a633f585f5a9cd19c6f7fff42266e

See also #4410
@amaitland amaitland self-assigned this Mar 7, 2023
amaitland added a commit to cefsharp/CefSharp.MinimalExample that referenced this issue Mar 7, 2023
@amaitland
High-DPI support is now enabled by default in Chromium
6cb9b3c 
- Remove DPI entries from app.manifest
- Remove Cef.EnableHighDPISupport (Method will be removed in M113 (cefsharp/CefSharp#4417))

Issue cefsharp/CefSharp#4410
amaitland added a commit that referenced this issue Mar 7, 2023
@amaitland
Core - High-DPI support is now enabled by default in Chromium.
b17cd2a 
- Chromium now enables DPI awareness programmatically by default
- Remove Cef.EnableHighDPISupport calls and mark as obsolete
- Remove dpiawareness entries from app.manifest

Issues #4417 #4410
amaitland added a commit that referenced this issue Mar 13, 2023
@amaitland
Net Core - Remove EnableHighDPISupport from BrowserSubProcess
7bfcaef 
- NetCore has it's own exe which still had a call to EnableHighDPISupport
- WPF seems to default to System DPI aware, revert to using app.manifest for PerMonitorV2

Follow up to b17cd2a

Issues #4417 #4410
amaitland added a commit that referenced this issue Mar 13, 2023
@amaitland
Net Core - Remove EnableHighDPISupport from BrowserSubProcess
ae2e797 
- NetCore has it's own exe which still had a call to EnableHighDPISupport
- WPF seems to default to System DPI aware, revert to using app.manifest for PerMonitorV2

Follow up to b17cd2a

Issues #4417 #4410
@amaitland amaitland added this to the 112.2.x milestone Mar 15, 2023
amaitland added a commit to cefsharp/CefSharp.MinimalExample that referenced this issue Apr 24, 2023
@amaitland
Net Core - Remove Cef.EnableHighDPISupport
d8957e0 
- Method was removed upstream (cefsharp/CefSharp#4417)
- Update WPF to set DPI awareness in app.manifest
amaitland added a commit to cefsharp/CefSharp.MinimalExample that referenced this issue Apr 24, 2023
@amaitland
Net Core - Remove Cef.EnableHighDPISupport
ae3ff97 
- Method was removed upstream (cefsharp/CefSharp#4417)
- Update WPF to set DPI awareness in app.manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amaitland amaitland

Labels
api-change breaking-change
Projects
None yet
Milestone
112.2.x
Development

No branches or pull requests
1 participant
@amaitland