Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ChromiumWebBrowser.GetContentSizeAsync return type #4427

Closed
amaitland opened this issue Mar 14, 2023 · 0 comments
Closed

Change ChromiumWebBrowser.GetContentSizeAsync return type #4427

amaitland opened this issue Mar 14, 2023 · 0 comments
Assignees
@amaitland
Labels
api-change breaking-change
Milestone
112.2.x

Comments

@amaitland
Copy link
Member

Current return type is DevTools.DOM.Rect, this will be changed to a new type DomRect which will have exactly the same params.

The DevTools generated API will be moved from CefSharp.dll to CefSharp.Core.dll
@amaitland amaitland added this to the 112.2.x milestone Mar 14, 2023
@amaitland amaitland self-assigned this Mar 14, 2023
amaitland added a commit that referenced this issue Mar 14, 2023
@amaitland
Core - Move DevTools Client from CefSharp.dll to CefSharp.Core.dll
fb779a5 
- Moves the Dependency of System.Text.Json from CefSharp.dll
  BrowserSubProcess as a result no longer has a reference
  where wasn't required for it's operation.

Resolves #4428 #4427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amaitland amaitland

Labels
api-change breaking-change
Projects
None yet
Milestone
112.2.x
Development

No branches or pull requests
1 participant
@amaitland