Update DependencyChecker IsWindowsXp Flag to evaluate Environment #1018
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. Thanks! Bill |
rassilon
added a commit
that referenced
this pull request
May 8, 2015
Automatically detect Windows XP.
|
@rassilon Just a reminder to update the changelog. Thanks! 😄 |
|
Heh. Unless we produce a build that works on xp, doesn't seem worth the effort. (low as it is) :) |
|
Hmm, still relevant for people who choose to build from source. |
amaitland
changed the title
|
I've amended the title slight and added to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #1007, here is a pull request containing only the change to automatically detect Windows XP:
Previously, it was the main program's responsibility to set
IsWindowsXpif necessary, but that was problematic because it wasn't possible to set it before its value was used. But it's easy enough to detect automatically anyway, so it's probably nicer to just do that.