SetCursor CefCursorType parameter #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuddlyogre
changed the title
| @@ -174,7 +174,7 @@ namespace CefSharp | |||
| virtual DECL void OnCursorChange(CefRefPtr<CefBrowser> browser, CefCursorHandle cursor, CursorType type, | |||
| const CefCursorInfo& custom_cursor_info) OVERRIDE | |||
| { | |||
| _renderWebBrowser->SetCursor((IntPtr)cursor); | |||
| _renderWebBrowser->SetCursor((IntPtr)cursor, (CefSharp::CefCursorType)type); | |||
There was a problem hiding this comment.
I've been using Intellij for so long. I had forgotten that the tab key inserts a tab character sometimes.
|
Thanks for the PR @cuddlyogre 👍 Just a few formatting and commit cleaning issues to sort out. |
|
Oh and when you do clean up the issues, remember to leave a new comment here. This ensures the project maintainers get an email notification. We don't get told about further commits alone. |
|
I have made the requested changes. |
| { | ||
| public enum CefCursorType | ||
| { | ||
| CT_POINTER = 0, |
There was a problem hiding this comment.
Can you remove the CT_ prefix and make these proper case. Bring them inline with .Net styling.
e.g. CT_POINTER becomes Pointer
|
The changes to the CefCursorType names has been made. |
amaitland
added a commit
that referenced
this pull request
May 25, 2015
SetCursor CefCursorType parameter
|
Great, thanks 👍 |
|
You're very welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetCursor now receives the cursor type. The enums for the types come directly from CEF.