Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChromeWidgetMessageInterceptor to WinForms Example #1138

Merged
merged 4 commits into from
Jul 23, 2015

Conversation

jankurianski
Copy link
Member

Addresses #570

@amaitland amaitland added this to the 43.0.0 milestone Jul 22, 2015
@jankurianski
Copy link
Member Author

Anyone have corrections or thoughts before I merge this?

@amaitland
Copy link
Member

Only question I have is would it be better to explicitly release the handle?

@amaitland
Copy link
Member

If it's working then I'm happy to merge is as, few formatting things, they can be sorted later 👍

@jankurianski
Copy link
Member Author

Only question I have is would it be better to explicitly release the handle?

It is working without releasing the handle, but it may be inadvertently preventing garbage collection. So I have made it explicitly release the handle now.

@jankurianski
Copy link
Member Author

Add browser.HandleDestroyed -= BrowserHandleDestroyed;?

Good catch 👍

@amaitland
Copy link
Member

Might be worth adding the extra example from #1098 (comment)

Can be commented out, just as a user reference?

@jankurianski
Copy link
Member Author

Might be worth adding the extra example from #1098 (comment)

Can be commented out, just as a user reference?

Good thinking. I might actually change the ChromeWidgetMessageInterceptor to accept an Action<Message> delegate, then it can be up to the caller to do what they wish with the widget messages.

@jankurianski
Copy link
Member Author

I added a comment about mouse events.

I also moved moved the ToolStrip-closing logic into BrowserTabUserControl. Any thoughts?

@amaitland
Copy link
Member

Looks fine 👍

jankurianski added a commit that referenced this pull request Jul 23, 2015
Add ChromeWidgetMessageInterceptor to WinForms Example
@jankurianski jankurianski merged commit 44a13c3 into cefsharp:master Jul 23, 2015
@jankurianski jankurianski deleted the example/menu-closer branch July 23, 2015 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants