Add support for JSB in Popups #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… across multiple CefBrowserWrapper instances (popups in this context) Code is now very much dependant on using --process-per-tab for this structure to work
…r simple class doesn't need the extra overhead of a cpp file)
…d the object No need to store a reference to them long term
…OnRenderViewReady) Remove IsPopup check from async binding
Still have the issue of callbacks not working as expect, for some reason it can't find the context
…p the browser by it's Id for callbacks
amaitland
added a commit
that referenced
this pull request
Sep 28, 2015
Add support for JSB in Popups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
-process-per-tabto makeJSBwork propery (was previously only added to43branch).Added link to
BindingTest.htmlin thePopup Test Custom Schememenu itemBoth standard and
asyncJSBshould now work in popups. Have only tested with opening a popup on the samescheme, so may need some more testing.