Add support for JSB with frames #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can be executed on a specific frame Resolves a problem where multiple contexts are created and only the first one is dealt with properly (each frame has it's own V8 context)
…aitland/CefSharp into fix-v8contextperframe-destructor
…r, added comment to clarify the missing destructor call
…arpper message handling
|
@amaitland I have tried your solution and it is still possible to crash CEF. (process crash for popups, render process crash for usual page) I've created a PR on your repository which I believe fixes the remaining issues. |
…nt/v8contextperframe
…aitland/CefSharp into fix-v8contextperframe-destructor
Adjustment for the v8 context per frame implementation
amaitland
added a commit
that referenced
this pull request
Oct 13, 2015
Add support for JSB with frames
|
@illfang Thanks for your hard work on this 👍 I've merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation only works with a single context per
CefBrowserwrapper, when multiple frames are added a newV8Contextis created perFrame.This
PRis based on/inspired by #1319Support for a
JavascriptRootObjectWrapperperV8Contexthas been added. EachJS CallbackandAsync Methodcall now includes aFrameId, so they can be associated with the correct wrapper.I haven't yet done extensive testing, it appears to work. The changes are quite fiddly as params passed using the native
IPCare index based. (At some point a layer of abstraction needs to be added to handle this complexity as it's a little hard to follow at the moment, It was a deliberate decision to avoid doing that as yet, I though it was more important to fully understand the problem domain before attempting to engineer a solution).