Fix offscreen browser browser settings nullptr #1358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug with the optional browser settings in the offscreen browser project which will lead to a null poiinter exception if no settings are available.
Example:
https://github.com/illfang/CefSharp/tree/offscreen-browser-browser-settings-nullptr-test
Probably related to dca52f9
I suggest two version to fix this. This is the first version which will always create the offscreen browser using the instance settings, request context and address. The instance browser settings are checked for null in the constructor.
The second solution is described in /pull/1359
I'm looking forward to your feedback. Feel free to close one of the PRs if you decide to merge one.