Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Chinese IME input #211

Merged
merged 7 commits into from
Jan 21, 2014
Merged

Handle Chinese IME input #211

merged 7 commits into from
Jan 21, 2014

Conversation

shen6041
Copy link
Contributor

Chinese、Japanese IME input text can be recieved,but with IME pad still not following the caret.

@perlun
Copy link
Member

perlun commented Nov 11, 2013

Hi,

Thanks for your pull request. However, please clean it up so you use spaces (not tabs) and also consistent spacing around identifiers, like the rest of the code base. (See the "Files Changes" tab and I think you will get what I mean.)

@shen6041
Copy link
Contributor Author

ok~
i tried to clean up the space but i didn't catch the point of using the editor in web.
i will edit it and request again.

@jstdoit
Copy link

jstdoit commented Jan 14, 2014

你修改的版本是WinForm的么?我在WPF版本里面输入法依然没法使用,求解决

@shen6041
Copy link
Contributor Author

@jstdoit I don't know whether this commit has been accepted or not.you may copy my changes into your own code.

@jstdoit
Copy link

jstdoit commented Jan 21, 2014

@perlun Have you accepted @shen6041 pull request?

@jstdoit
Copy link

jstdoit commented Jan 21, 2014

@perlun I pull your CefSharp1 branch, then I run the wpf example, the input pad still not follows the caret. as screenshot attached.
qq20140121-1

@jstdoit
Copy link

jstdoit commented Jan 21, 2014

I found WinForm uses ImeMode to set Ime behaviors, link:http://msdn.microsoft.com/en-us/library/system.windows.forms.imemode(v=vs.110).aspx
and this link: http://msdn.microsoft.com/en-us/library/windows/desktop/ee419002(v=vs.85).aspx#default_ime_behavior
Will this help you to solve problems?

@perlun
Copy link
Member

perlun commented Jan 21, 2014

@jstdoit - generally, "open pull request" means that it has not been accepted. In this case because of some space/tabs issues. Will look into it to see if I can get it sorted out.

perlun added a commit that referenced this pull request Jan 21, 2014
perlun added a commit that referenced this pull request Jan 21, 2014
…errors was introduced in the PR though, some was pre-existent)
@perlun perlun merged commit b121f93 into cefsharp:CefSharp1 Jan 21, 2014
@perlun
Copy link
Member

perlun commented Jan 21, 2014

@jstdoit - I've now merged the PR, so please give it a try now to verify if it works. (by compiling CefSharp1 from source)

@shen6041 - Please, could you take a look if CefSharp3 is affected by the same issues, and if so, submit PR:s towards that branch also? Otherwise, we will run into the exact same issues there, once that branch goes live...

@jstdoit
Copy link

jstdoit commented Jan 21, 2014

@perlun @shen6041 Now I can input Chinese char, but the input window still now follows the caret. Any solution for this?

@perlun
Copy link
Member

perlun commented Jan 21, 2014

Not that I'm aware of unfortunately. 😞

Someone who actually has this equipment should take a look at it, I suggest, and make a PR that fixes the remaining issues. Care to give it a try? It's much harder for me, since I use a standard Swedish keyboard (which is basically A-Z + a few Scandinavian characters like åäö...), and don't own an IME pad.

Thanks in advance.

@jstdoit
Copy link

jstdoit commented Jan 21, 2014

@perlun I just want to help to do something, but I'm not that used to C#, but I can suggest you to install one. :-)

@shen6041
Copy link
Contributor Author

@jstdoit there is some apis that can set window position,which may be helpfull to solve this ime pad following problem,i will look into it.

@shen6041
Copy link
Contributor Author

@perlun ok,i will look into it if get time avaliable.

@jstdoit
Copy link

jstdoit commented Jan 22, 2014

@shen6041 Come on, spring festival is coming 💯

@loundar
Copy link

loundar commented Dec 1, 2014

朋友你好,请问是学习cefsharp项目的吗?如果是敬请加入中国区cefsharp学习交流qq群 211927319,很多问题或许根本就不是问题,只是我们对程序了解太少,不妨一起学习,真正遇到问题的时候,再来这里开辟issue麻烦作者更好

@xland xland mentioned this pull request Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants