Adding cookie expiration granularity to setcookies. #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mmm, small yet looking like a very very crunchy PR 🍪 - congrats on your first PR! Good contribution! I'll let Per decide on when it should be merged though ... I have no experience with CEF cookie handling - yet! |
|
Thanks @jornh - the cookies are very tasty. |
|
Merging now. Thanks for a clean and nice pull request! Very easy to see what the actual changes were on this one. 👍 |
perlun
added a commit
that referenced
this pull request
Mar 28, 2014
Adding cookie expiration granularity to setcookies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddCookie api does not handle cookies with expiration times that are more granular then a day.