Feature/device scale factor #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 27, 2015 10:33
…ing. This will provide the correct area available for rendering.
|
Width and height are already transformed, so I'm a little concerned. I'm contemplating reverting the previous changes until more testing/feedback have been conducted. I think we should ask upstream for clarification |
|
Yes. The previuos change will not behave correctly without this last change. Might be a good idea to check upstream. We will anyway deploy this to production. It's better than nothing, for now. |
amaitland
added a commit
that referenced
this pull request
Mar 2, 2015
… can be conducted - need to look more info how scale factor works and if the ScaleTransform we have is required.
|
I've merged in the changed, and commented them out in a later commit. When I tried with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change needed to function correctly. (Proper render area)
I've also investigated a bit on the scale transform. It seems like CreateBitmapSourceFromMemorySection returns an image source with DpiX and DpiY set to 96 regardless of the actual dpi on the system. This is probably why the image is bitmap up-scaled. So for now the transform is needed to compensate for this.