-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance StreamAdapter to more effeciently deal with MemoryStream #856
Enhance StreamAdapter to more effeciently deal with MemoryStream #856
Conversation
…h MemoryStreams, and add lame header to ResourceHandler usage in CefExample.cs. Additionally, allocate Headers NameValueCollection in constructor.
Looks like the build failed due to the following line in
|
I was thinking we do the |
@@ -17,6 +17,7 @@ namespace CefSharp | |||
{ | |||
CriticalSection _syncRoot; | |||
gcroot<Stream^> _stream; | |||
bool isMemoryStream = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In C++
we prefix with _
(I would like to make the C#
code consistent, though I've had some resistance).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In next push.
Bill |
Enhance StreamAdapter to more effeciently deal with MemoryStream
...emoryStreams, and add lame header to ResourceHandler usage in CefExample.cs.
Additionally, allocate Headers NameValueCollection in constructor of ResourceHandler.
Sadly, without a change to ClientAdapter.cpp to pass the header data to CEF due to a debug flavor bug in CEF, you can't easily test this change. :(
If you do test this with the CEF change or a Release flavor with the ClientAdapter.cpp change, then this works correctly.
Bill