Rename IResourceHandler to IResourceHandlerFactory. #857
Conversation
| { | ||
| void RegisterHandler(string url, ResourceHandler handler); | ||
|
|
||
| void UnregisterHandler(string url); | ||
|
|
||
| /// <summary> | ||
| /// Called before a resource is loaded. To specify a handler for the resource return a ResourceHandler object | ||
| /// Called before a resource is loaded. To specify a handler for the resource return a ResourceHandlerFactory object |
There was a problem hiding this comment.
Little bit to aggressive with the rename? I think this should still be ResourceHandler
|
I'm happy with I think the rename may have been a little too aggressive, at least a couple of instances that I think should stay as Other than that, rename away. |
| @@ -54,11 +54,11 @@ public interface IWebBrowser : IDisposable | |||
| void Load(string url); | |||
|
|
|||
| /// <summary> | |||
| /// Registers and loads a <see cref="ResourceHandler"/> that represents the HTML content. | |||
| /// Registers and loads a <see cref="ResourceHandlerFactory"/> that represents the HTML content. | |||
There was a problem hiding this comment.
Possibly this should stay the same as well? (And the next few instances).
Feel free to improve the comments as you see fit.
There was a problem hiding this comment.
Yes they should. Fixed.
|
@jankurianski Is renaming going to cause you any problems? |
|
Will wait for feedback from @jankurianski before merging this one as he's likely to be affected. Were you planning any other changes? I know you'd mentioned switching to a |
|
Yeah, I do want to switch this to a After Either via a known Bill |
|
Sure. I think the Bill |
Sounds like the best of both worlds 👍 |
|
@amaitland My apologies for the delay - I am not affected by this. I also think @rassilon would be a great addition to the team! |
No problem 👍 Thanks for confirming. |
Rename IResourceHandler to IResourceHandlerFactory.
|
Sorry Alex, must have overlooked this one 😊 I'm very much in favour of adding @rassilon to the team as well. Bill, welcome aboard! From what I've seen you have already contributed significantly to CefSharp in a very short span of time... Very much appreciated 👍 |
No problem at all 😄 |
Start the process of cleaning up
IResouceHandlerby renaming it something sensible.Thoughts?
If you think the name is ok, I'll push a rename of the files.
Bill