Passing IsMainFrame as parameter to the OnBeforeBrowse #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,7 +16,7 @@ public interface IRequestHandler | |||
| /// <param name="request">the request object - cannot be modified in this callback</param> | |||
| /// <param name="isRedirect">has the request been redirected</param> | |||
There was a problem hiding this comment.
Can you add additional please?
|
Thanks 👍 |
amaitland
added a commit
that referenced
this pull request
Mar 18, 2015
Passing IsMainFrame as parameter to the OnBeforeBrowse
|
Since this commit my Cefsharp WinXP/VS2010 builds stopped working on Windows 7-8 (yes I got all building and working fine in XP), when I attach IRequestHandler to ChromiumWebBrowser it tells me that "Method not found Boolean CefSharp.IRequestHandler.OnBeforeBrowse (CefSharp.IWebBrowser, CefSharp.IRequest, Boolean, Boolean). But this method IS PRESENT both in CefSharp.IRequestHandler.cs and in my project's class implementing this interface. I'm wondering what can be wrong here? update: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #829. Adding
IsMainFrameto theOnBeforeBrowsemethod.