Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DefaultFocusHandler public class #890

Merged
merged 1 commit into from
Mar 18, 2015

Conversation

rassilon
Copy link
Contributor

instead of internal so that you can subclass and reuse the tricky default OnGotFocus implementation.

Add doc comment warnings about the danagers of overriding IFocusHandler.OnGotFocus for WinForm ChromiumWebBrowsers.

Thoughts?
Bill

…blic instead of internal so that you can subclass and reuse the tricky default OnGotFocus implementation.

Add doc comment warnings about the danagers of overriding IFocusHandler.OnGotFocus for WinForm ChromiumWebBrowsers.
@amaitland amaitland added this to the 39.0.0 milestone Mar 18, 2015
@amaitland
Copy link
Member

I remember making the methods virtual, guess it would help if the class was public 😄

amaitland added a commit that referenced this pull request Mar 18, 2015
@amaitland amaitland merged commit 06a797a into cefsharp:master Mar 18, 2015
@amaitland
Copy link
Member

Merged 👍

@rassilon rassilon deleted the MakeDefaultFocusHandlerPublic branch March 20, 2015 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants