Don't change .Address when popups display #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would have though |
|
IsPopup did indeed work just fine apparently. |
rassilon
added a commit
that referenced
this pull request
Mar 21, 2015
Don't change the .Address property when (among other things) you display...
rassilon
changed the title
|
Still need the main frame check I believe. Otherwise ifames etc will change the url also. |
|
Looks like the frame check isn't required anymore 👍 From memory it was added for a reason, just can't remember what for. Also possible the behavior of |
|
Cool. Thank's for checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ought to be pretty straightforward.
I wasn't sure if just checking IsPopup was good enough.
The existing test wasn't good enough because DevTools is the main frame for the popup DevTools browser.
Bill