WPF Popup - Change to absolute positioning #916
Conversation
This avoids win 8/8.1 menu alignment settings
| popup.HorizontalOffset = popupOffset.X / matrix.M11; | ||
| popup.VerticalOffset = popupOffset.Y / matrix.M22; | ||
| var locationFromScreen = this.PointToScreen(popupOffset); | ||
| var targetPoint = |
There was a problem hiding this comment.
Use matrix to perform the transform.
|
@svantreeck Couple of minor changes, apart from that looks solid 👍 Thanks for the contribution! |
|
I updated the code...tested and working on windows 10. I'll check it out on a few other boxes (8.1 and 7) tomorrow morning to double check things look ok there because things didn't look correct with DPI scaling when I first turned it tried the code in Win10, so now that its right there, I very possibly messed up on 7/8/8.1 |
No problem, |
amaitland
changed the title
|
It looks fine to me on win 8.1, I think its good to go unless you can see any issues with it. |
|
It will need testing using a range of scenarios. Does it work under win 7? |
|
Looks like the |
| @@ -1067,9 +1067,10 @@ private void SetPopupSizeAndPositionImpl(int width, int height, int x, int y) | |||
| popup.Width = width; | |||
There was a problem hiding this comment.
I think we need to scale the width and height from the results I'm seeing on Win7 at 1.25
|
I would second that...I have a screen with 150% scaling and was getting an ugly black background around the edges. Commited an update to scale the width and height by the matrix. |
Great 👍 Can you give a quick summary of all the combinations you've tested with so far? Basically looks like it's working now, just need to make sure we haven't missed anything before committing. |
|
I've tested on: |
WPF Popup - Change to absolute positioning
This avoids win 8/8.1 menu alignment settings where they can cause devices to not show relative positioned popups where expected.
This fixes issue #906