Call GetZoomLevel On CEF UI Thread #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a failure mode of just returning 0. Here's a cheesy temporary solution to adding a full on GetZoomLevelAsync method that returns a .Net task.
amaitland
changed the title
| @@ -110,7 +110,7 @@ | |||
| <ClCompile> | |||
| <Optimization>Disabled</Optimization> | |||
| <AdditionalIncludeDirectories>$(SolutionDir)packages\$(CefSdkVer)\CEF;%(AdditionalIncludeDirectories);$(ProjectDir)</AdditionalIncludeDirectories> | |||
| <PreprocessorDefinitions>_DEBUG;_WIN32_WINNT=0x0600;WINVER=0x0600;WIN32;_WINDOWS;WIN32_LEAN_AND_MEAN;USING_CEF_SHARED;_CRT_SECURE_NO_WARNINGS;EXPORT;%(PreprocessorDefinitions)</PreprocessorDefinitions> | |||
| <PreprocessorDefinitions>_DEBUG;_WIN32_WINNT=0x0600;WINVER=0x0600;WIN32;_WINDOWS;WIN32_LEAN_AND_MEAN;USING_CEF_SHARED;_CRT_SECURE_NO_WARNINGS;EXPORT;OS_WIN;%(PreprocessorDefinitions)</PreprocessorDefinitions> | |||
There was a problem hiding this comment.
Does CEF require OS_WIN to be set?
There was a problem hiding this comment.
It does if you want the base::Bind(...) overloads for __stdcall. (Sadly, Marshal.GetNativeFunctionPointerForDelegate doesn't like generic delegates or generic parameters. 😦 So that atttempt didn't work either. Ugh.
I figured it would probably be good to leave it in case CEF uses the define for other stuff.
Bill
There was a problem hiding this comment.
It does if you want the base::Bind(...) overloads for __stdcall.
I couldn't figure out what changes in this PR would require a new pre-processor directive, makes sense now. Since it has a potential purpose then happy to leave in 👍
|
Works as advertised 👍 Merge away. |
rassilon
added a commit
that referenced
this pull request
Apr 16, 2015
Call GetZoomLevel On CEF UI Thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetZoomLevel is required to be called from the UI thread, but it has a failure mode of just returning 0 when its not on the UI thread. Here's a cheesy temporary solution to avoid adding a full on GetZoomLevelAsync method that returns a .Net task.
Bill