Add BrowserSubProcess dependency checking. #959
Conversation
| var browserSubprocessDir = Path.GetDirectoryName(browserSubProcessPath); | ||
| if (browserSubprocessDir == null) | ||
| { | ||
| missingDependencies.AddRange(BrowserSubprocessDependencies); |
There was a problem hiding this comment.
Should there be a CheckDependencyList call here?
There was a problem hiding this comment.
No at this point browserSubProcessPath is something that doesn't exist, so everything that should be in there is by default missing. I considered adding browserSubProcessPath itself to the collection instead, but that didn't seem consistent with the rest of the code. Also browserSubProcessPath could be null and then there's not enough explanation of what's wrong.
|
I made one small tweak, more from a style/readability point of view Other than that, looks solid 👍 Thanks! |
|
When I tried in So temporarily I've disabled if the debugger is attached see 3e3ea4f Previously the |
|
In my dev environment |
|
I use I've never had a problem with either previously. |
|
Yeah I have VS 2013 at work. So much for that theory. |
|
|
|
Yup. |
|
It's easy enough to add a I'll try on my work machine later, it has both |
|
I'm also curious but I'm out of ideas. I don't know too much about the rules for loading and sharing libraries in Windows. OS is Windows 8.1 Enterprise here. Maybe there's some obscure security policy that's relevant? Programming in VS without ReSharper is sadness. |
|
@amaitland , maybe we could ask for ReSharper/NDepend OpenSource licenses for CefSharp? That'd be very cool. |
|
I believe at one point in time @perlun had organized I'd like to try out |
|
I have that, yes. Give me your email (perlun in Google Mail) and I'll see what I can do. Didn't even know about ReSharper for C++, that sounds incredibly nice, since C++ is so horrible to work with otherwise. 😛 |
It was only just released a couple of weeks ago. See release announcement for some pretty detailed info http://blog.jetbrains.com/dotnet/2015/04/10/introducing-resharper-cpp/ |
Email sent, thanks 👍 |
|
Ditto, thanks 👍 |
|
Hey @perlun, @amaitland , the NDepend folks got back to me, they are still willing to give out licenses for OSS projects, however they require additional details in order to issue the licenses. I emailed @perlun about it in hopes he'd reply-all to all of us via email about it, but I haven't heard back yet. I'm <firstname>.<lastname> at Google Mail. You can find that info in my github profile now. Fyi, |
Nice one 👍
Out of curiosity? What sort of information are they asking for? |
|
Postal address & phone number. |
|
@amaitland , would you like to be included on the NDepend thing? |
|
Sure. Best to email? |
|
Yeah. See previous comment about my email address. I've edited the Markdown so it renders properly now. |
|
Email sent. |
No description provided.