-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build automation for cef-binary #5
Comments
No comments... 😄
Be my guest! Here is my attempt so far. As you see, I didn't get very far. 😉 The hard bit is about chaining the
It is a word. You just created it. 😀 |
This is what was used to build the cef.sdk.3.1650.1562-pre2 NuGet currently on staging.nuget.org It comes with extra DRYness which CefSharp.Core now relies on since the SHA a7590937 commit jornh/CefSharp@a759093 <CefSdkVer>cef.sdk.3.1650.1562-pre2</CefSdkVer> in cef.sdk.props does that Note: Contents in the CEF/ folder is currently still a manual cherrypick from building upstream CEF Resolution of this is tracked in #5
Btw, I already added the Rakefile into the repo if you didn't already see it. |
Yes, saw it. Good start and the &&'s are a neat solution to the chaining problem. 👍 Still first I think I will spend a little time on tightening things up on native NuGets etc. & follow up with FAQ etc. when people start using them ... |
Thanks. I didn't know about && on Windows myself, but apparently, it's there...
I see. My reference to FAQ was more so we can avoid the (obvious) question of "why can I not just clone the CefSharp code and build" (since the package restore needs to be done manually). |
Yes - both the obvious one you mention and probably other variants that will crop up. There recently was some "FUD"/confusion in the Google group regarding NuGet references etc. And I think I actually might have added to it with my comment there. 😢 needs to be straightened out ... |
With the excellent |
This is what was used to build the cef.sdk.3.1650.1562-pre2 NuGet currently on staging.nuget.org It comes with extra DRYness which CefSharp.Core now relies on since the SHA a7590937 commit jornh/CefSharp@a759093 <CefSdkVer>cef.sdk.3.1650.1562-pre2</CefSdkVer> in cef.sdk.props does that Note: Contents in the CEF/ folder is currently still a manual cherrypick from building upstream CEF Resolution of this is tracked in #5 Former-commit-id: 2a52f02e08a3afebfe124a06b6ab14700e7d2497
This is what was used to build the cef.sdk.3.1650.1562-pre2 NuGet currently on staging.nuget.org It comes with extra DRYness which CefSharp.Core now relies on since the SHA a7590937 commit jornh/CefSharp@a759093 <CefSdkVer>cef.sdk.3.1650.1562-pre2</CefSdkVer> in cef.sdk.props does that Note: Contents in the CEF/ folder is currently still a manual cherrypick from building upstream CEF Resolution of this is tracked in #5 Former-commit-id: 2a52f02e08a3afebfe124a06b6ab14700e7d2497
Over in the CefSharp repo - in cefsharp/CefSharp#288 (comment) @perlun suggested better automation. I think this belong in this repo - so here's an issue for it, with my comments so far ...
Hey, I thought you said with a
Rakefile
it would be a one-liner ... did you stop in the middle of the line ;-)Brilliant thought - I have actually started the same - but in BAT ... eek ... based on https://github.com/coapp-packages/pixman/blob/master/COPKG/build.bat
I'll see if I can get to it before you.
cinst'ing
(should be a word!) FTWThe text was updated successfully, but these errors were encountered: