Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to can haz CEF3.1650.1532 (Chromium 31) #1

Merged
merged 6 commits into from
Mar 7, 2014

Conversation

jornh
Copy link
Contributor

@jornh jornh commented Mar 7, 2014

I'm able to build the libcef_dll_wrapper.lib in a VS2010 and a VS2013 Developer Command Prompt.
Hope it works with VS2012 too!

Pristine apart from one place where we cheat/save some megabytes by
reusing the /Release/libcef.dll in the /Debug folder too.

Per did the same trick back in the CEF3 1413 and 1547 daysv- see
SHA:d966747aba61397f918761073616a9868e0b1448
Same storry as previous commit for x64: Pristine apart from one place
where we cheat/save some megabytes by reusing the /Release/libcef.dll in
the /Debug folder too.

Per did the same trick back in the CEF3 1413 and 1547 days- see
SHA: d966747
- includes the .props include to handle builds for VS201x variants
- and the /wd4275 compiler warning disable
All this should give us four libcef_dll_wrapper.lib files ready for
CefSharp consumption for both x86/x64/Debug/Release when running
build.bat twice - for each compiler ... phew...
This should be the first and last time we need this fix because it's
fixed upstream in CEF see
https://code.google.com/p/chromiumembedded/issues/detail?id=1094 - but
that is unfortunately after the official pristine binary release at
r1562
- official location now at cefsharp team on GH
- fix a few broken links because we now have both Win32 and x64
- Mention VS2013
@perlun
Copy link
Member

perlun commented Mar 7, 2014

Yay! Very cool work mate. 😄 Did you manage to find & fix the bug you mentioned some week ago, with the stability?

I don't have any VS at the moment (since I'm on the aforementioned paternity leave 😃) but I will try to review this one as fast as I can. Nonetheless, really really good work there!

@jornh
Copy link
Contributor Author

jornh commented Mar 7, 2014

No need to hurry! Now it's visible to whoever looks at the official repo (probably very few have an interest in this "plumbing") so you can just let it sit there.

I think I confused a couple of issues back then so I actually think what I have with Chromium 31 is as stable/unstable as the current Chromium 29 based trunk 😃

One issue I saw was the known WinForms chrash on exit. Another thing might be that when the libcef_dll_wrapper project is built with /MD(d) the cefclient.exe isn't linkable. (But who cares 😈 ) And then finally I might still have some kind of issue with VS2013 - either due to my setup or because it's still quite new with CEF.

Next steps on this will be work on the PR for the cefsharp/CefSharp#237 repo unless I can find something else to get sidetracked by 📺 🍻 or 📧

@perlun
Copy link
Member

perlun commented Mar 7, 2014

No need to hurry! Now it's visible to whoever looks at the official repo (probably very few have an interest in this "plumbing") so you can just let it sit there.

Well, it looks good enough (I skimmed through the commits) so I think I'll go ahead and merge now, even though I haven't yet tested it w/ VS2012. This repo is hardly used by that many people anyway, so it should be fair game.

I think I confused a couple of issues back then so I actually think what I have with Chromium 31 is as stable/unstable as the current Chromium 29 based trunk

Hehe, ok cool. 😃

One issue I saw was the known WinForms chrash on exit. Another thing might be that when the libcef_dll_wrapper project is built with /MD(d) the cefclient.exe isn't linkable. (But who cares 😈 )

That one is actually quite easy to fix; you just have to use /MD(d) for cefclient.exe also. Possibly also disable some other compiler warning. I think it worked with my (pre-your-changes) master. If you have time, please look into it, since it's quite handy to be able to have a working cefclient.exe sometimes (especially when you're not sure if something is a CefSharp or a CEF bug...).

perlun added a commit that referenced this pull request Mar 7, 2014
Update to can haz CEF3.1650.1532 (Chromium 31)
@perlun perlun merged commit 89ed4ae into cefsharp:master Mar 7, 2014
@perlun
Copy link
Member

perlun commented Mar 7, 2014

@jornh, one more thing that would be cool (and perhaps help you w/ cefsharp/CefSharp#237 also) is to make a separate .bat file that takes care of copying the files into the CefSharp working copy (i.e. the output .lib files and such)

Ideally, the .bat file would detect which VS command prompt you are running and copy the files to the right place. Shouldn't be that hard I guess.

Ideally v 2.0, all of this would be in a Rakefile, not even requiring you to use a specific VS command prompt... instead, you just run one single rake command and it would build using vs2010, vs2012 and vs2013. Since not all of these might always be available, it would make sense to set up separate Rake targets for each VS version (so you can do e.g. rake vs2013 to just build & copy the files from that build into the target folder.)

If you know Rake - please go for that route. If you have never used Ruby or Rake, feel free to choose the .bat approach instead (which I can then refactor into a Rakefile).

(I love Ruby. It makes you realize why you don't really need intellisense, if the language is well-designed enough... 😃)

@jornh
Copy link
Contributor Author

jornh commented Mar 7, 2014

one more thing ...

Yes, is already cooking! The idea with DevEnv detection is neat though - will add that !

cefclient.exe with /MD

Will look briefly into it - till now I just fetched from http://www.magpcss.net/cef_downloads/index.php?query=label%3A~Deprecated+label%3Aclient+label%3Awindows+sort%3Aname#list then we know for sure cefsharp are not to blame 😄

I'm have more Python (and at some point SCons for VS etc builds) than Ruby/rake experience. It looks like that is also more in line with what CEF/Chromium use ... But it's not a religion to me. For now I think I will stay with .bat for this.

merceyz pushed a commit that referenced this pull request Apr 12, 2017
Update to can haz CEF3.1650.1532 (Chromium 31)

Former-commit-id: 9f411b0cd26eb82505b4f2ab0b30c565639253da
merceyz pushed a commit that referenced this pull request Apr 12, 2017
Update to can haz CEF3.1650.1532 (Chromium 31)

Former-commit-id: 9f411b0cd26eb82505b4f2ab0b30c565639253da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants