Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep meta data around task, even after disabled. #352

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Keep meta data around task, even after disabled. #352

wants to merge 1 commit into from

Conversation

vbabiy
Copy link
Contributor

@vbabiy vbabiy commented Jun 13, 2020

  • added total_run_count to the admin
  • don't clear out last_run_at, on disabling a task.
  • don't clear out total_run_count on one of tasks.

auvipy
auvipy requested changes Jun 14, 2020
View reviewed changes
django_celery_beat/models.py
@@ -574,8 +574,6 @@ def save(self, *args, **kwargs):
self.routing_key = self.routing_key or None
self.queue = self.queue or None
self.headers = self.headers or None
if not self.enabled:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this create any regreassion?

django_celery_beat/schedulers.py
@@ -125,7 +125,6 @@ def is_due(self):
if self.model.one_off and self.model.enabled \
and self.model.total_run_count > 0:
self.model.enabled = False
self.model.total_run_count = 0 # Reset
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it backward-incompatible?

@auvipy auvipy closed this Oct 13, 2022
@auvipy auvipy reopened this Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbabiy @auvipy