Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MySQL max length issue. #410

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix MySQL max length issue. #410

wants to merge 2 commits into from

Conversation

jeffkit
Copy link

@jeffkit jeffkit commented May 26, 2021

Fix the same issue in django_celery_result project.

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change really needed?

@jeffkit
Copy link
Author

jeffkit commented Jun 6, 2021

is this change really needed?

Yes, this issue is also exist in the earlier version of django_celery_result project. Check the readme for detail.

we use utf8-mb4 as our mysql default chartset encoding, when migrating django_celery_beat, it fail with an error:
django.db.utils.OperationalError: (1071, 'Specified key was too long; max key length is 767 bytes')

@auvipy
Copy link
Member

auvipy commented Jun 15, 2021

hopefully the change is not going to break existing codes

@auvipy
Copy link
Member

auvipy commented Jun 15, 2021

can you check the comments of this PR and improve this one https://github.com/celery/django-celery-beat/pull/202/files?

@auvipy auvipy added this to the v2.3.0 milestone Mar 1, 2022
@auvipy auvipy removed this from the v2.3.0 milestone Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants