Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A unit Test to make sure ClockedSchedule and PeriodicTasks are shown in TimeZone format #485

Merged
merged 7 commits into from
Apr 11, 2022
Merged

A unit Test to make sure ClockedSchedule and PeriodicTasks are shown in TimeZone format #485

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3947863
Fix ClockedSchedule showing UTC time and ignoring Timezone
Dec 3, 2021
13d403a
Force datatime to have timezone information
Dec 15, 2021
6333d67
Merge branch 'celery:master' into master
moreaba Dec 15, 2021
b0a7df3
Force datatime to have timezone information-removing unused import
Dec 15, 2021
be7901b
Merge branch 'celery:master' into master
moreaba Dec 17, 2021
d094414
A unit test to make sure ClockedSchedule and PeriodicTasks are not sh…
Dec 19, 2021
7bfbf6a
fix grammer/typo
auvipy Dec 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion t/unit/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
from django.db.migrations.loader import MigrationLoader
from django.db.migrations.questioner import NonInteractiveMigrationQuestioner
from django.utils import timezone

from django.conf import settings
import pytz, datetime
import timezone_field

from django_celery_beat import migrations as beat_migrations
Expand Down Expand Up @@ -146,3 +147,12 @@ class ClockedScheduleTestCase(TestCase, TestDuplicatesMixin):
def test_duplicate_schedules(self):
kwargs = {'clocked_time': timezone.now()}
self._test_duplicate_schedules(ClockedSchedule, kwargs)

# IMPORTANT: we must have a valid time-zone (not UTC) to do an accurate testing
@override_settings(TIME_ZONE='Africa/Cairo')
def test_timezone_format(self):
"""Make sure the scheduled time is not shown in UTC when time zone is used"""
tz_info = pytz.timezone(settings.TIME_ZONE).localize(datetime.datetime.utcnow())
schedule, created = ClockedSchedule.objects.get_or_create(clocked_time=tz_info)
# testnig str(schedule) calls make_aware() internally
assert str(schedule.clocked_time) == str(schedule)